Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Moved the TriggerGroups to stable #1345

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Moved the TriggerGroups to stable #1345

merged 1 commit into from
Apr 14, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Apr 11, 2022 •
edited
Loading

TriggersGroups has been moved to stable API from alpha api. It will be available by default and no changes in config will be required.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

TriggerGroups will be available by default. No changes in config will be required for running it.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 11, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go 98.0% 98.0% -0.0

@khrm
Copy link
Contributor Author

khrm commented Apr 11, 2022

/test pull-tekton-triggers-integration-tests

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Apr 11, 2022

/test pull-tekton-triggers-integration-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go 98.0% 98.0% -0.0

@khrm
Moved the TriggerGroups to stable
e342539 
TriggersGroups has been moved to stable API from alpha api. It
will be available by default and no changes in config will be required.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go 98.0% 98.0% -0.0

@khrm khrm added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 13, 2022
@khrm khrm linked an issue Apr 13, 2022 that may be closed by this pull request
Move TriggerGroups to stable #1321
Closed
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@dibyom
Copy link
Member

dibyom commented Apr 14, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@tekton-robot tekton-robot merged commit cd31af1 into tektoncd:main Apr 14, 2022
@khrm khrm deleted the tg2stable branch August 9, 2022 18:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move TriggerGroups to stable
3 participants
@khrm @tekton-robot @dibyom