Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove redundant struct PodTemplate from types #1347

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Remove redundant struct PodTemplate from types #1347

merged 1 commit into from
Apr 14, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Apr 13, 2022 •
edited
Loading

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 13, 2022
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 13, 2022
@khrm khrm added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 13, 2022
dibyom
dibyom approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@dibyom
Copy link
Member

dibyom commented Apr 13, 2022

/hold

look like this contains the yaml changes too

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@khrm
Remove redundant struct PodTemplate from types
24b7f47 
Remove the podtemplate struct from types.
@khrm khrm force-pushed the redundantStruct branch from eb7e3bf to 24b7f47 Compare April 14, 2022 14:38
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@khrm
Copy link
Contributor Author

khrm commented Apr 14, 2022

@dibyom Removed that yaml.

@dibyom
Copy link
Member

dibyom commented Apr 14, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@khrm
Copy link
Contributor Author

khrm commented Apr 14, 2022

I think we can remove the hold here. @dibyom

@dibyom
Copy link
Member

dibyom commented Apr 14, 2022

oops sorry
/hold cacnel

@dibyom
Copy link
Member

dibyom commented Apr 14, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2022
@khrm
Copy link
Contributor Author

khrm commented Apr 14, 2022

/test pull-tekton-triggers-integration-tests

@tekton-robot tekton-robot merged commit 693f951 into tektoncd:main Apr 14, 2022
@khrm khrm changed the title Redundant struct Remove redundant struct PodTemplate from types May 12, 2022
@khrm khrm deleted the redundantStruct branch August 9, 2022 19:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khrm @tekton-robot @dibyom