Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Multiarch Image in Getting Started #1362

Merged
merged 1 commit into from
May 10, 2022
Merged

Add Multiarch Image in Getting Started #1362

merged 1 commit into from
May 10, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented May 10, 2022 •
edited
Loading

Curl in 'create-webhook.yaml' of getting started is quite old and only amd64. Changed it
to official image 'curlimages/curl:latest' for multiarch support. This enables us to run getting started in Apple's M1 chip.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@khrm
Add Multiarch Image in Getting Started
7e70961 
Curl in 'create-webhook.yaml' of getting started is quite old and only amd64. Changed it 
to official image 'curlimages/curl:latest' for multiarch support.
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 10, 2022
@tekton-robot tekton-robot requested review from dibyom and wlynch May 10, 2022 11:48
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 10, 2022
@khrm khrm added the kind/misc Categorizes issue or PR as a miscellaneuous one. label May 10, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
dibyom
dibyom approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dibyom,savitaashture]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit e6a4ab8 into main May 10, 2022
@khrm khrm deleted the curl-multiarch branch May 10, 2022 20:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@savitaashture savitaashture savitaashture approved these changes

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @dibyom @savitaashture