Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update RBAC link to point to k8s docs #1411

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Update RBAC link to point to k8s docs #1411

merged 1 commit into from
Aug 8, 2022

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Aug 4, 2022 •
edited
Loading

Changes

Fixes #1408

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2022
@dibyom
Copy link
Member Author

dibyom commented Aug 4, 2022

/release-note-none

@tekton-robot
Copy link

@dibyom: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

khrm
khrm reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@khrm
Copy link
Contributor

khrm commented Aug 4, 2022

/test pull-tekton-triggers-integration-tests

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@khrm
Copy link
Contributor

khrm commented Aug 4, 2022

/test pull-tekton-triggers-integration-tests

1 similar comment
@khrm
Copy link
Contributor

khrm commented Aug 4, 2022

/test pull-tekton-triggers-integration-tests

@khrm
Copy link
Contributor

khrm commented Aug 4, 2022

This flakiness should be resolved by #1412

khrm
khrm reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-tekton-triggers-integration-tests

khrm
khrm reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-tekton-triggers-integration-tests

@tekton-robot tekton-robot merged commit 49d2a03 into main Aug 8, 2022
@dibyom dibyom deleted the dibyom-patch-1 branch August 8, 2022 14:43
@savitaashture savitaashture added documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. labels Sep 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@khrm khrm khrm left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] RBAC link points to google cloud docs
4 participants
@dibyom @tekton-robot @khrm @savitaashture