Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move CloudEvent to Stable #1414

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Move CloudEvent to Stable #1414

merged 1 commit into from
Nov 9, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Aug 9, 2022 •
edited
Loading

Move CloudEvent to Stable from alpha api.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

For pull requests that don't need to be mentioned at release time, use the /release-note-none Prow command to add the release-note-none label to the PR. You can also write the string "NONE" as a release note in your PR description:

cloudEventURI field can be used in stable APIs now.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 9, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2022
khrm
khrm commented Aug 9, 2022
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 9, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go 98.0% 97.9% -0.1

@dibyom
Copy link
Member

dibyom commented Aug 10, 2022

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@khrm khrm requested a review from dibyom August 10, 2022 16:26
@dibyom
Copy link
Member

dibyom commented Aug 11, 2022

I think we have to update the docs too

@savitaashture savitaashture added this to the Triggers v0.21.0 milestone Aug 24, 2022
@savitaashture savitaashture assigned khrm and unassigned khrm Aug 24, 2022
@khrm
Copy link
Contributor Author

khrm commented Sep 5, 2022

We haven't added this in the documentation. So I created a separate pr. We will merge this in next pr.

@khrm
Copy link
Contributor Author

khrm commented Sep 6, 2022

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@savitaashture savitaashture removed this from the Triggers v0.21.0 milestone Sep 6, 2022
@khrm khrm added this to the Triggers v0.22.0 milestone Sep 6, 2022
@khrm
Copy link
Contributor Author

khrm commented Sep 12, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
savitaashture
savitaashture reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@khrm
Move CloudEvent to Stable
11738d3 
Move CloudEvent to Stable from alpha api.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. labels Nov 9, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go 98.0% 97.9% -0.1

@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022
@tekton-robot tekton-robot merged commit 9ad4d63 into tektoncd:main Nov 9, 2022
@khrm khrm deleted the f/CE2Stable branch February 28, 2023 04:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@vtereso vtereso Awaiting requested review from vtereso

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @dibyom @savitaashture