Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add examples for Bitbucket Cloud and Update doc #1428

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add examples for Bitbucket Cloud and Update doc #1428

merged 1 commit into from
Sep 1, 2022

Conversation

savitaashture
Copy link
Contributor

Changes

  • Add example for Bitbucket Cloud
  • Update example of Bitbucket to Bitbucket Server because the current Bitbucket example supported by Triggers is for Bitbucket Server
  • Update doc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Add example support for Bitbucket Cloud

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 23, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 23, 2022
khrm
khrm reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Are examples in v1alpha1 needed? I don't think we need to add examples to v1alpha1.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@savitaashture savitaashture force-pushed the add-bitbucket-example branch from 6ec3b6b to d86d654 Compare August 23, 2022 14:54
dibyom
dibyom reviewed Aug 23, 2022
View reviewed changes
docs/interceptors.md Outdated

### Bitbucket Server

A Bitbucket Server `Interceptor` contains logic that validates and filters [Bitbucket server](https://confluence.atlassian.com/bitbucketserver) webhooks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @savitaashture I think separating out the difference between server and cloud is great. One minor thing is that from the docs it seems like we have two separate interceptors. We only have one bitbucket interceptor which supports secret validation and event filtering for bitbucket server and only event filtering for bitbucket cloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye looks like that
Updated now
PTAL

docs/interceptors.md Outdated

A [Bitbucket cloud](https://support.atlassian.com/bitbucket-cloud/) is free to use and explore functionality, To know more about Bitbucket Cloud [follow](https://support.atlassian.com/bitbucket-cloud/docs/get-started-with-bitbucket-cloud/).
Bitbucket Cloud doesn't support secret validation; hence its not secure compare to Bitbucket Server.
[CEL `Interceptor`](#cel-interceptors) also used to get the similar functionality of Bitbucket Cloud.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line.

docs/interceptors.md Outdated
### Bitbucket Cloud

A [Bitbucket cloud](https://support.atlassian.com/bitbucket-cloud/) is free to use and explore functionality, To know more about Bitbucket Cloud [follow](https://support.atlassian.com/bitbucket-cloud/docs/get-started-with-bitbucket-cloud/).
Bitbucket Cloud doesn't support secret validation; hence its not secure compare to Bitbucket Server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Bitbucket Cloud doesn't support secret validation; hence its not secure compare to Bitbucket Server.
At the moment, Bitbucket cloud does not support validating webhook payloads using shared secrets. See the [Secure Webhooks section](https://support.atlassian.com/bitbucket-cloud/docs/manage-webhooks/) of Bitbucket cloud docs for more information on securing your bitbucket webhooks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated
Thank you

docs/interceptors.md Outdated

### Bitbucket Cloud

A [Bitbucket cloud](https://support.atlassian.com/bitbucket-cloud/) is free to use and explore functionality, To know more about Bitbucket Cloud [follow](https://support.atlassian.com/bitbucket-cloud/docs/get-started-with-bitbucket-cloud/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to describe what Bitbucket cloud is given that we do not do it for other providers.

@savitaashture savitaashture force-pushed the add-bitbucket-example branch from d86d654 to e67997f Compare August 24, 2022 08:37
@savitaashture
Copy link
Contributor Author

/approve Are examples in v1alpha1 needed? I don't think we need to add examples to v1alpha1.

@khrm removed bitbucket-cloud from v1alpha1 and kept bitbucket-server as it is because earlier we had bitbucket related example in v1alpha1

@savitaashture savitaashture added this to the Triggers v0.21.0 milestone Aug 24, 2022
@savitaashture savitaashture self-assigned this Aug 24, 2022
dibyom
dibyom approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 07c6387 into tektoncd:main Sep 1, 2022
@savitaashture savitaashture added documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. labels Sep 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@khrm khrm khrm left review comments

@dibyom dibyom dibyom approved these changes

@bigkevmcd bigkevmcd Awaiting requested review from bigkevmcd

Assignees

@dibyom dibyom

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @tekton-robot @khrm @dibyom