Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove redundant code for chan in TLS ticker #1460

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Remove redundant code for chan in TLS ticker #1460

merged 1 commit into from
Oct 10, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Oct 10, 2022 •
edited
Loading

Removing the redundant code for chan quit in Ticker. No function ever sends data to quit chan, so it is never satisfied. We can safely remove it and keep running the loop based on ticker duration.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@khrm khrm requested a review from savitaashture October 10, 2022 16:57
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 10, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 27.5% 28.8% 1.3

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2022
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 27.5% 29.7% 2.2

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 27.5% 29.7% 2.2

@khrm
Remove redundant code for chan in Ticker
447ed37 
Removing the redundant code for chan `quit` in Ticker. No function
ever sends data to `quit` chan, so it is never satisfied. We can safely
remove it and keep running the loop based on ticker duration.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 27.5% 28.8% 1.3

dibyom
dibyom approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@tekton-robot tekton-robot merged commit 811e571 into main Oct 10, 2022
@khrm khrm deleted the khrm-patch-1 branch October 10, 2022 19:29
khrm
khrm commented Oct 11, 2022
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@savitaashture savitaashture Awaiting requested review from savitaashture

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khrm @tekton-robot @dibyom