Set default Interceptor.Kind for EventListener TriggerGroups
#1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tektoncd#1499 While `Kind` is getting defaulted properly for interceptors in `EventListener.Spec.Triggers`, it also needs to be defaulted for interceptors in `EventListener.Spec.TriggerGroups`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
added
kind/bug
tekton-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
dibyom
added
the
needs-cherry-pick
|
/cherry-pick release-v0.22.x |
2 similar comments
|
/cherry-pick release-v0.22.x |
|
/cherry-pick release-v0.22.x |
|
@dibyom: new pull request created: #1508 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1499
While
Kindis getting defaulted properly for interceptors inEventListener.Spec.Triggers, it also needs to be defaulted for interceptors inEventListener.Spec.TriggerGroups./kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes