Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove the GO111MODULE=off in release pipeline #1536

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 23, 2023

GO111MODULE=off causes an error while fetching vcs version. Function debug.ReadBuildInfo requires binaries to be built with module support.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

GO111MODULE=off causes an error while fetching vcs version.
Function debug.ReadBuildInfo requires binaries to be built with module support.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Feb 23, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2023
@khrm khrm requested review from dibyom and savitaashture and removed request for savitaashture February 23, 2023 06:47
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 23, 2023
@khrm
Copy link
Contributor Author

khrm commented Feb 24, 2023

/test pull-tekton-triggers-build-tests

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@tekton-robot tekton-robot merged commit 11453aa into main Feb 27, 2023
@khrm khrm deleted the khrm-patch-2 branch February 28, 2023 04:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants