Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Point Gitlab Interceptors docs to more direct Webhook event types link #1786

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

AndrewTasso
Copy link
Contributor

@AndrewTasso AndrewTasso commented Dec 20, 2024

Changes

Revise docs to point to Gitlab Docs that contain the full list of Webhook event types, instead of a generic description of Webhook events.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 20, 2024
@tekton-robot tekton-robot requested a review from dibyom December 20, 2024 16:19
Copy link

linux-foundation-easycla bot commented Dec 20, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot requested a review from khrm December 20, 2024 16:19
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2024
@tekton-robot
Copy link

Hi @AndrewTasso. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AndrewTasso
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 20, 2024
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2025
@khrm
Copy link
Contributor

khrm commented Jan 24, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@savitaashture savitaashture added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@savitaashture
Copy link
Contributor

/retest

@khrm
Copy link
Contributor

khrm commented Feb 5, 2025

/test pull-tekton-triggers-integration-tests

@AndrewTasso
Copy link
Contributor Author

@khrm I'm a bit fuzzy on how a single line documentation change is causing a failed build. What's the next steps to fry this merged?

@savitaashture
Copy link
Contributor

/test tekton-triggers-unit-tests

@tekton-robot tekton-robot merged commit a920e8c into tektoncd:main Feb 5, 2025
6 checks passed
@khrm
Copy link
Contributor

khrm commented Feb 5, 2025

This failure was due to some issue with plumbing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants