Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ImagePullSecrets field when create Deployment by EventListener #1787

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

lx1036
Copy link
Contributor

@lx1036 lx1036 commented Dec 30, 2024

Changes

fixed #1448

when submit EventListener like this with imagePullSecrets now:

apiVersion: triggers.tekton.dev/v1beta1
kind: EventListener
metadata:
  name: fission-ci-listener-test
spec:
  serviceAccountName: tekton-triggers-example-sa
  resources:
    kubernetesResource:
      spec:
        template:
          spec:
            imagePullSecrets:
              - name: docker-login
  triggers:
    - interceptors:
        - ref:
            name: cel
          params:
            - name: filter
              value: 'body.gitUrl != "" && body.gitRevision != "" && body.oauth != ""'
      bindings:
        - ref: fission-ci-binding-test
      template:
        ref: fission-ci-template-test

it report errors like:

$ k apply -f eventlister.yaml -n tekton-run
Error from server (BadRequest): error when creating "eventlister.yaml": admission webhook "validation.webhook.triggers.tekton.dev" denied the request: validation failed: must not set the field(s): spec.resources.kubernetesResource.spec.template.spec.imagePullSecrets

this PR resolve the issue that deployment with imagePullSecrets by EventListener.

Release Notes

None

@tekton-robot
Copy link

@lx1036: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

linux-foundation-easycla bot commented Dec 30, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 30, 2024
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 30, 2024
@tekton-robot
Copy link

Hi @lx1036. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2024
@lx1036 lx1036 force-pushed the feature/add-imagepullsecrets branch from 83c4622 to bf5b195 Compare December 30, 2024 11:34
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2025
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/eventlistener/resources/deployment.go 100.0% 98.6% -1.4

@khrm
Copy link
Contributor

khrm commented Jan 2, 2025

Please sign the cla

@lx1036
Copy link
Contributor Author

lx1036 commented Jan 18, 2025

ok, has signed CLA, thanks.

@savitaashture
Copy link
Contributor

savitaashture commented Feb 3, 2025

@lx1036 can you add a unit tests and update doc may be in the followup PR

cc @khrm if looks ok can we merge so that we can include this in the Triggers release

@savitaashture savitaashture added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 4, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@savitaashture savitaashture added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
@khrm
Copy link
Contributor

khrm commented Feb 5, 2025

/retest

@savitaashture
Copy link
Contributor

/test tekton-triggers-unit-tests

@tekton-robot tekton-robot merged commit 1952ecc into tektoncd:main Feb 5, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tekton trigger controller support args "-el-image-pull-secrets" for pull eventlistenersink docker image
4 participants