Add the images folder in triggers sync config

[afrittoli]

Changes

Pull in SVG images from triggers docs/images into the main docs
folder, so that we can display it correctly.

Partially addresses #340

Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vovtz]

/reopen
Apparently didn’t get any attention, didn’t get approved nor denied

[vovtz]

/reopen

Apparently didn’t get any attention, didn’t get approved nor denied

[tekton-robot]

@vovtz: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Apparently didn’t get any attention, didn’t get approved nor denied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dibyom]

@afrittoli @AlanGreene @geriom does it make sense to reopen this to fix #453 and #340

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from afrittoli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[vovtz]

/remove-lifecycle stale

Just needs a little bit of attention (I would do it myself if I had a bit of knowledge about the setup of the docs).

[geriom]

I spent most of the day trying to figure this out. So far no success but I noticed a few things:

1. The exact line that breaks the links is 299 in sync.py. The statement if fq_path in local_files: checks whether relative links point to valid cloned files, if not they are turned into (incorrect) absolute links. At first I thought the error was in this giving false negatives, but..
2. This works correctly in one instance. Opening the the main tag in the vault docs: http://localhost:8888/vault/triggers-main/ works fine.
3. I checked the other versions of the same docs and none of them have the images folder other than main. So my guess is that the sync script is not handling correctly all the tags. There are inconsistencies in other repos too.

I will look into this some more tomorrow.

[geriom]

Opened #490 with an alternative solution. If the image is not found locally, use the URL to the raw file on github.

Closing this one.