Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fakesnow fails due to missing pandas module, even when pandas isn't required #127

Closed
somnam opened this issue Aug 21, 2024 · 1 comment · Fixed by #128
Closed

fakesnow fails due to missing pandas module, even when pandas isn't required #127

somnam opened this issue Aug 21, 2024 · 1 comment · Fixed by #128

Comments

@somnam
Copy link

somnam commented Aug 21, 2024

It seems that the latest release causes pandas to be a hard dependency when using fakesnow but for some cases it may not be required.

Package versions:

  • fakesnow==0.9.23
  • snowflake-connector-python==3.12.0

Example script triggering the error:

import fakesnow
import snowflake.connector

with fakesnow.patch():
    connection = snowflake.connector.connect(
        account=settings.ACCOUNT,
        user=settings.USER,
        password=settings.PASSWORD,
        warehouse=settings.WAREHOUSE,
        database=settings.DATABASE,
        authenticator=settings.AUTHENTICATOR,
    )

ModuleNotFoundError: No module named 'pandas'

Should pandas be required as a dependency when installing fakesnow?

@tekumara
Copy link
Owner

Oops, this was broken by 8c21935 thanks for reporting this!

tekumara pushed a commit that referenced this issue Aug 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.9.24](v0.9.23...v0.9.24)
(2024-08-21)


### Bug Fixes

* don't require pandas at import time
([2a7944e](2a7944e)),
closes [#127](#127)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: potatobot-prime[bot] <132267321+potatobot-prime[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants