This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Add option for (dis)allowing an empty string in prompter #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
| @@ -66,7 +66,7 @@ export class Prompter implements IPrompter { | |||
| return future; | |||
| } | |||
|
|
|||
| public getPassword(prompt: string, options?: {allowEmpty?: boolean}): IFuture<string> { | |||
| public getPassword(prompt: string, options?: IAllowEmpty): IFuture<string> { | |||
There was a problem hiding this comment.
Can't we have default action here? Why not using IPrompterOptions?
There was a problem hiding this comment.
I'd rather not have a default action here because I can't imagine a case where one'd want a default action to take if a password is not provided.
If, on the other hand, we use IPrompterOptions here and just don't respect the defaultAction that would be misleading to the coder.
Mitko-Kerezov
force-pushed
the
kerezov/allow-nonempty-string
branch
2 times, most recently
from
0d33fbb to
07e8719
Compare
|
Ping @rosen-vladimirov for a double-chek after fixing the comment |
|
❤️ |
1 similar comment
|
❤️ |
| if(defaultAction) { | ||
| schema.default = defaultAction; | ||
| if(options && options.defaultAction) { | ||
| schema.default = options.defaultAction; |
There was a problem hiding this comment.
maybe we can remove the if:
schema.default = options && options.defaultAction;
|
👍 after considering my comment for default action |
Mitko-Kerezov
force-pushed
the
kerezov/allow-nonempty-string
branch
from
07e8719 to
6c5a141
Compare
|
❤️ |
Mitko-Kerezov
added a commit
that referenced
this pull request
Mar 2, 2016
Add option for (dis)allowing an empty string in prompter
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented to facilitate calls requiring nonempty strings.
Ping @rosen-vladimirov