Improvements to Health Probe Server (CORE-69) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Runs on a background thread and configures the Grizzly thread pool to a small size to improve responsiveness and reduce resource usage - Now listens on 0.0.0.0 so more reliably usable in containerised runtimes - ServerBuilder now supports configuring the maximum thread pool size - Various background threads now make an effort to set their Thread Name to something meaningful to aid debugging
TelicentPaul
previously approved these changes
Jul 10, 2024
cli/cli-probe-server/src/main/java/io/telicent/smart/cache/cli/probes/HealthProbeServer.java
Outdated
Show resolved
Hide resolved
cli/cli-probe-server/src/main/java/io/telicent/smart/cache/cli/probes/HealthProbeServer.java
Outdated
Show resolved
Hide resolved
Move an unnecessary wait in the HealthProbeServer implementation into its test cases instead. Cleans up unused imports across various test classes
|
@TelicentPaul Addressed your comments so needs a fresh review |
TelicentPaul
approved these changes
Jul 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.0.0so more reliably usable in containerised runtimesRelated Issues