Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Bump jakarta.ws.rs:jakarta.ws.rs-api from 3.1.0 to 4.0.0" #92

Conversation

rvesse
Copy link
Contributor

@rvesse rvesse commented Jan 8, 2025

Reverts #84

This is causing strange build/run issues in downstream consumers of these libraries due to changes in their major version bump. It's not clear that Jersey properly supports JAX-RS 4 yet so until it does we should avoid taking this upgrade

@rvesse rvesse requested a review from TelicentPaul January 8, 2025 10:14
@rvesse rvesse self-assigned this Jan 8, 2025
@rvesse rvesse requested a review from robwtelicent January 8, 2025 10:14
Copy link
Contributor

@TelicentPaul TelicentPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll have a few dependency PRs in the coming days

@rvesse rvesse merged commit d2ae07f into main Jan 8, 2025
27 checks passed
@TelicentPaul
Copy link
Contributor

What's odd is that the tests all passed despite this issue. Something to consider?

@rvesse rvesse deleted the revert-84-dependabot/maven/jakarta.ws.rs-jakarta.ws.rs-api-4.0.0 branch January 8, 2025 10:33
@rvesse
Copy link
Contributor Author

rvesse commented Jan 8, 2025

What's odd is that the tests all passed despite this issue. Something to consider?

Yeah I guess the tests all construct fairly "toy" web applications. I was getting all sorts of cryptic ClassNotFound errors both at compile and runtime in a repository where there was a real-world application present

@robwtelicent
Copy link
Contributor

What's odd is that the tests all passed despite this issue. Something to consider?

Yeah I guess the tests all construct fairly "toy" web applications. I was getting all sorts of cryptic ClassNotFound errors both at compile and runtime in a repository where there was a real-world application present

Sounds like those downstream consumers were pulling in this dependency transitively from this repo, whereas they have an actual undeclared dependency on the older version. Adding dependency analysis to their repos should clear that up. Job for another day perhaps!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants