Restore wrongly scoped Jersey related dependencies #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with 0.26.0 release was still getting strange runtime errors in downstream repositories. On further investigation realised this was become some dependencies has been erroneously moved to test scope when they were in fact required for servers to run correctly. They were wrongly classified by dependency analysis as unused because they are not directly used, rather indirectly via Service Loading. This also explains why the tests here didn't fail as these dependencies has simpy been moved to test scope so they were present for the tests and allowed those to pass successfully.
TelicentPaul
approved these changes
Jan 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with 0.26.0 release was still getting strange runtime errors in downstream repositories. On further investigation realised this was become some dependencies has been erroneously moved to test scope when they were in fact required for servers to run correctly. They were wrongly classified by dependency analysis as unused because they are not directly used, rather indirectly via Service Loading.
This also explains why the tests here didn't fail as these dependencies has simpy been moved to test scope so they were present for the tests and allowed those to pass successfully.