Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(rdfInstanceViewer): Add literals #6

Merged
merged 10 commits into from
May 10, 2024
Merged

feat(rdfInstanceViewer): Add literals #6

merged 10 commits into from
May 10, 2024

Conversation

davec504
Copy link
Contributor

@davec504 davec504 commented May 9, 2024

Switched out libraries from rdf-parse to n3, this allows better parsing and writing of rdf

Added logic to add and remove literals.

Store all quads in an N3 store

Fixed logic to work with new store and fixed tests

The entire graph is generated via the RDF

fixed TELFE-95

Switched out libraries from rdf-parse to n3, this allows
better parsing and writing of rdf

Added logic to add and remove literals.

Store all quads in an N3 store

Fixed logic to work with new store and fixed tests

The entire graph is generated via the RDF
Copy link
Contributor

@dptelicent dptelicent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might be still in dev or not relevant for this PR and I don't fully understand intended functionality, but:

  1. Deleting an object property from the RDF does not remove the corresponding edge from the graph.
  2. Attribute behaviour:
  • Deleting an attribute from the graph also deletes the related node.
  • If multiple attributes are added for a node, they are visible in the RDF but only one is visible on the graph.
  • Attributes are not removed from the graph when deleted from the RDF.
Screen.Recording.2024-05-10.at.10.22.46.mov

src/Core/FakeHttpGateway.ts Outdated Show resolved Hide resolved
src/lib/CustomNode/ClassInstanceNode.tsx Outdated Show resolved Hide resolved
src/rdfInstanceViewer/RdfInstancePresenter.ts Outdated Show resolved Hide resolved
src/rdfInstanceViewer/RdfInstancePresenter.ts Outdated Show resolved Hide resolved
src/rdfInstanceViewer/RdfInstancePresenter.ts Show resolved Hide resolved
src/rdfInstanceViewer/RdfInstancePresenter.ts Outdated Show resolved Hide resolved
davec504 and others added 5 commits May 10, 2024 10:39
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: A Coolman <153610820+ACoolmanTelicent@users.noreply.github.com>
Copy link
Contributor

@ACoolmanTelicent ACoolmanTelicent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few pretty-naive suggestions. Nothing blocking

@davec504
Copy link
Contributor Author

davec504 commented May 10, 2024

These might be still in dev or not relevant for this PR and I don't fully understand intended functionality, but:

  1. Deleting an object property from the RDF does not remove the corresponding edge from the graph.

I imagine this is when you are deleting an object property of a node -> dataTypeProperty. Node -> Node edges will work as expected. With regards to the former it is a bit clunky and I will raise a ticket to address it, but it has been deemed ok for now.

  1. Attribute behaviour:
  • Deleting an attribute from the graph also deletes the related node.

Yes, this is related to the previous comment, this is because both nodes share the same id, we do need to add additional checks on the term types to handle situations like this and I will raise a ticket, but stakeholders aware of this limitation and ok with it for now.

  • If multiple attributes are added for a node, they are visible in the RDF but only one is visible on the graph.

Need to check with @afizzycola if you can have multiple dataTypeProperties off of one node in the first place. Should be a 1-1 relationship. Will raise a ticket ticket.

  • Attributes are not removed from the graph when deleted from the RDF.

I could not reproduce, maybe your RDF syntax is incorrect.

Screen.Recording.2024-05-10.at.10.22.46.mov

VeeKemp
VeeKemp previously approved these changes May 10, 2024
@dptelicent
Copy link
Contributor

dptelicent commented May 10, 2024

All good apart from:

#6 (comment)

#6 (comment)

and

  • Attributes are not removed from the graph when deleted from the RDF.

I could not reproduce, maybe your RDF syntax is incorrect.

@davec504 sent you a video as upload failed here.

Uploading Screen Recording 2024-05-10 at 15.59.13.mov…

@davec504 davec504 dismissed stale reviews from VeeKemp and ACoolmanTelicent via b23835a May 10, 2024 14:43
dptelicent
dptelicent previously approved these changes May 10, 2024
@davec504 davec504 dismissed stale reviews from dptelicent and ACoolmanTelicent via 2019b18 May 10, 2024 16:28
@ACoolmanTelicent ACoolmanTelicent self-requested a review May 10, 2024 16:30
@davec504 davec504 merged commit cede62a into main May 10, 2024
1 check passed
@davec504 davec504 deleted the switch-to-n3 branch May 10, 2024 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants