-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(rdfInstanceViewer): Add literals #6
Conversation
Switched out libraries from rdf-parse to n3, this allows better parsing and writing of rdf Added logic to add and remove literals. Store all quads in an N3 store Fixed logic to work with new store and fixed tests The entire graph is generated via the RDF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might be still in dev or not relevant for this PR and I don't fully understand intended functionality, but:
- Deleting an object property from the RDF does not remove the corresponding edge from the graph.
- Attribute behaviour:
- Deleting an attribute from the graph also deletes the related node.
- If multiple attributes are added for a node, they are visible in the RDF but only one is visible on the graph.
- Attributes are not removed from the graph when deleted from the RDF.
Screen.Recording.2024-05-10.at.10.22.46.mov
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: dptelicent <109953637+dptelicent@users.noreply.github.com>
Co-authored-by: A Coolman <153610820+ACoolmanTelicent@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few pretty-naive suggestions. Nothing blocking
I imagine this is when you are deleting an object property of a node -> dataTypeProperty. Node -> Node edges will work as expected. With regards to the former it is a bit clunky and I will raise a ticket to address it, but it has been deemed ok for now.
Yes, this is related to the previous comment, this is because both nodes share the same id, we do need to add additional checks on the term types to handle situations like this and I will raise a ticket, but stakeholders aware of this limitation and ok with it for now.
I could not reproduce, maybe your RDF syntax is incorrect.
|
All good apart from: and
@davec504 sent you a video as upload failed here. Uploading Screen Recording 2024-05-10 at 15.59.13.mov… |
2019b18
Switched out libraries from rdf-parse to n3, this allows better parsing and writing of rdf
Added logic to add and remove literals.
Store all quads in an N3 store
Fixed logic to work with new store and fixed tests
The entire graph is generated via the RDF
fixed TELFE-95