-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(console): support "no prompt" mode #661
Merged
brendt
merged 7 commits into
tempestphp:main
from
innocenzi:feat/console/support-no-interactions
Nov 6, 2024
Merged
feat(console): support "no prompt" mode #661
brendt
merged 7 commits into
tempestphp:main
from
innocenzi:feat/console/support-no-interactions
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11640109947Details
💛 - Coveralls |
I merged #660, feel free to rebase, I'll review afterwards, but I'm fairly confident this can be merged 👍 |
innocenzi
force-pushed
the
feat/console/support-no-interactions
branch
from
November 2, 2024 14:06
c1b783b
to
444ca2e
Compare
Thanks! Rebased, and ready for review |
brendt
requested changes
Nov 3, 2024
…` without prompting
innocenzi
force-pushed
the
feat/console/support-no-interactions
branch
from
November 6, 2024 00:22
444ca2e
to
0c7b699
Compare
brendt
approved these changes
Nov 6, 2024
Let's go!! 🌊 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a "no prompt" mode. This mode can be enabled by passing the
--no-interaction
flag to any command.That mode disables all user interactions with the console. Instead, default values will be used when provided, otherwise
null
or empty arrays will be returned by input components.To support this mode, some components and their static version needed a new
default
option, which this pull request includes.Additional changes:
Console
interface has a newdisablePrompting
anddisableTty
method to, well, disable prompting and TTY programmatically.interactiveSupported
is renamed tosupportsTty
, andsupportsPrompting
has been added. Both have been added to the interface and made public.ConsoleTester
class has a newwithoutPrompting
method to ease testing.dd
method toConsoleTester
, which is quite unrelated but I always try to reach for it.