Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(commandbus): async commands #685

Merged
merged 19 commits into from
Nov 14, 2024
Merged

feat(commandbus): async commands #685

merged 19 commits into from
Nov 14, 2024

Conversation

brendt
Copy link
Member

@brendt brendt commented Nov 6, 2024

Closes #314

TODO

  • Docs

@brendt brendt changed the title Async commands feat(commandbus): async commands Nov 7, 2024
@coveralls
Copy link

coveralls commented Nov 8, 2024

Pull Request Test Coverage Report for Build 11743263957

Details

  • 35 of 81 (43.21%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 82.172%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Tempest/CommandBus/src/HandleAsyncCommand.php 12 15 80.0%
src/Tempest/CommandBus/src/AsyncCommandRepositories/FileRepository.php 3 14 21.43%
src/Tempest/CommandBus/src/MonitorAsyncCommands.php 0 32 0.0%
Totals Coverage Status
Change from base Build 11734033828: -0.3%
Covered Lines: 7278
Relevant Lines: 8857

💛 - Coveralls

@brendt brendt marked this pull request as ready for review November 9, 2024 19:44
@brendt
Copy link
Member Author

brendt commented Nov 9, 2024

@aidan-casey @innocenzi can you give a review?

Copy link
Member

@innocenzi innocenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise: seems good to me. This is something we can improve on later to provide more advanced functionality, like balancing strategies.

Code-wise: just curious about the usage of HasConsole. Since we inject Console in the constructor anyway, why not use it directly?

@brendt
Copy link
Member Author

brendt commented Nov 12, 2024

Code-wise: just curious about the usage of HasConsole. Since we inject Console in the constructor anyway, why not use it directly?

No big reason for this… just something I've gotten used to as I prefer to call $this-> instead of $this->console.

@brendt brendt merged commit bfa1706 into main Nov 14, 2024
57 checks passed
@brendt brendt deleted the async-commands branch November 14, 2024 13:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async commands
3 participants