-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(commandbus): async commands #685
Conversation
Pull Request Test Coverage Report for Build 11743263957Details
💛 - Coveralls |
src/Tempest/CommandBus/src/AsyncCommandRepositoryInitializer.php
Outdated
Show resolved
Hide resolved
@aidan-casey @innocenzi can you give a review? |
src/Tempest/CommandBus/src/AsyncCommandRepositories/FileCommandRepository.php
Outdated
Show resolved
Hide resolved
src/Tempest/CommandBus/src/AsyncCommandRepositories/FileCommandRepository.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality-wise: seems good to me. This is something we can improve on later to provide more advanced functionality, like balancing strategies.
Code-wise: just curious about the usage of HasConsole
. Since we inject Console
in the constructor anyway, why not use it directly?
No big reason for this… just something I've gotten used to as I prefer to call |
57ff9df
to
feaf4f9
Compare
Closes #314
TODO