Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(http): map uploaded files into the request properties #702

Merged

Conversation

yassiNebeL
Copy link
Contributor

@yassiNebeL yassiNebeL commented Nov 8, 2024

fixed #370

make Upload files available, to easily resolve properties.
@yassiNebeL yassiNebeL changed the title feat (http): Mapping uploaded files into the request properties feat (http): mapping upload files into the request properties Nov 8, 2024
@yassiNebeL yassiNebeL changed the title feat (http): mapping upload files into the request properties feat(http): mapping upload files into the request properties Nov 8, 2024
@innocenzi innocenzi changed the title feat(http): mapping upload files into the request properties feat(http): map uploaded files into the request properties Nov 8, 2024
@yassiNebeL
Copy link
Contributor Author

yassiNebeL commented Nov 8, 2024

I updated the PR regarding the changes, however, the merging is still blocked.

@brendt also, I tried to upload multiple files to ensure that the mapping is correct; unfortunately the view component doesn't allow that yet.

@yassiNebeL yassiNebeL requested a review from brendt November 8, 2024 19:59
@brendt
Copy link
Member

brendt commented Nov 9, 2024

Could you please take a look at the failed CI runs?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11758117377

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.464%

Files with Coverage Reduction New Missed Lines %
src/Tempest/Http/src/Commands/ServeCommand.php 2 0.0%
Totals Coverage Status
Change from base Build 11751823795: -0.03%
Covered Lines: 7256
Relevant Lines: 8799

💛 - Coveralls

@yassiNebeL yassiNebeL force-pushed the map-upload-files-into-request-properties branch from ecd5ab5 to c43395e Compare November 9, 2024 17:33
@yassiNebeL
Copy link
Contributor Author

could you please review the PR now? all CI checks have passed!

@brendt brendt merged commit a97014c into tempestphp:main Nov 14, 2024
57 checks passed
@brendt
Copy link
Member

brendt commented Nov 14, 2024

Nice! Thanks :)

@yassiNebeL yassiNebeL deleted the map-upload-files-into-request-properties branch November 14, 2024 10:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Upload files into request properties
3 participants