feat(log): allow usage of multiple same log channels #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11788471385Details
💛 - Coveralls |
brendt
requested changes
Nov 12, 2024
brendt
approved these changes
Nov 12, 2024
|
Thanks! |
brendt
pushed a commit
that referenced
this pull request
Nov 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it isn't possible to correctly declare
AppendLogChannelmore than once inLogConfig. It will result in same log, being logged in same channel multiple times.This changes this behaviour, by storing
Monologinstance byspl_object_id, not class name.