Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #547 to add the
set
data type to the table statementsTo be honest I have a doubt about this implementation.
I think it can be confusing for end users to silently ignore this data type if not supported by the database. I did so inspired by
BelongsTo
orDropConstraint
statements but I prefer the way it's done inShowTables
which throw anUnsupportedDialect
exception.But this broke tests (or at least, I don't know how to handle multiples cases from a Dialect to an other)
Btw I think it can be a good point to try to be consistent in how handle this situation