Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Pr/bugfixes for PT-TEBD #71

Merged
merged 6 commits into from
Aug 7, 2022
Merged

Pr/bugfixes for PT-TEBD #71

merged 6 commits into from
Aug 7, 2022

Conversation

gefux
Copy link
Member

@gefux gefux commented Aug 7, 2022

Fixes #69 and #70, including test.

  • The contribution has been discussed and agreed on in the Issue section.
  • Code contributions do its best to follow the zen of python.
  • The automated test are all positive:
    • tox -e py36 (to run pytest) the code tests.
    • tox -e style (to run pylint) the code style tests.
    • tox -e docs (to run sphinx) generate the documentation.
  • Added test for changed/added code.
  • API code contributions include input checks (defensive code).
  • API code contributions include helpful error messages.
  • The documentation has been updated:
    • docstring for all new functions/methods/classes/modules.
    • consistent style of all docstrings.
    • for new modules: /docs/pages/modules.rst has been updated.
    • for api contributions: /docs/pages/api.rst has been updated.
    • for api contributions: tutorials and examples have been updated.

@gefux gefux merged commit c388c7c into tempoCollaboration:main Aug 7, 2022
@gefux gefux deleted the pr/bugfixes branch August 7, 2022 14:35
@gefux gefux mentioned this pull request Oct 7, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in SystemChain.add_site_dissipation()
1 participant
@gefux