Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Workflow start delay on CLI refresh #452

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 14, 2024

What was changed

Implemented #402 on CLI rewrite branch. Also fixed wrapping on some markdown content.

Checklist

  1. Closes CLI Refresh: Add start delay to workflow start #424

@cretz cretz requested a review from a team February 14, 2024 13:52
@@ -427,6 +430,8 @@ temporal workflow start \
* `--search-attribute` (string[]) - Passes Search Attribute in key=value format. Use valid JSON formats for value.
* `--memo` (string[]) - Passes Memo in key=value format. Use valid JSON formats for value.
* `--fail-existing` (bool) - Fail if the workflow already exists.
* `--start-delay` (duration) - Specify a delay before the workflow starts. Cannot be used with a cron schedule. If the
workflow receives a signal or update before the delay has elapsed, it will begin immediately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I confirm -- queries don't have this effect?

Copy link
Member Author

@cretz cretz Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so, but I just took this content verbatim from #402. I'd have to defer to start delay implementers to be sure, but proto docs just mention signal (they probably forgot to add update).

Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cretz cretz merged commit ccb85dc into cli-rewrite Feb 14, 2024
5 checks passed
@cretz cretz deleted the workflow-start-delay branch February 14, 2024 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants