Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix batch terminate test #488

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix batch terminate test #488

merged 1 commit into from
Feb 29, 2024

Conversation

stephanos
Copy link
Contributor

@stephanos stephanos commented Feb 29, 2024 •
edited
Loading

What was changed

Wrapped tests for batch terminate with Eventually.

Why?

Ensure the tests for batch terminate are not flaky.

Checklist

@stephanos stephanos changed the base branch from main to cli-rewrite February 29, 2024 22:05
@stephanos stephanos changed the title Cli rewrite batch eventually fix batch terminate test Feb 29, 2024
@stephanos stephanos changed the title fix batch terminate test fix batch terminate test Feb 29, 2024
@stephanos stephanos marked this pull request as ready for review February 29, 2024 22:32
@stephanos stephanos merged commit 9f32daf into temporalio:cli-rewrite Feb 29, 2024
6 checks passed
@josh-berry josh-berry mentioned this pull request Apr 29, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanos @cretz