Fix racy batch test #516
Merged
Fix racy batch test #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test occasionally fails because the batch job completes before the test has a chance to check its status. Allow for this case in the test.
|
hm... I'm realizing this is incomplete; the terminate test also has the same problem. It's less obvious how to fix that one, though, because success is indistinguishable from failure; if the batch job is already completed, it can't be terminated. (I'm seeing both failures on my Windows box pretty reliably.) I think this one can still be merged as-is, but someone (maybe/probably me) will need to do a follow-up PR for the terminate test. |
cretz
reviewed
Apr 2, 2024
cretz
approved these changes
Apr 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test occasionally fails because the batch job completes before the test has a chance to check its status. Allow for this case in the test.