Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

List schedules query param support #654

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

justinp-tt
Copy link
Contributor

What was changed

Support for schedule list query parameter

Why?

Checklist

  1. Closes
    [Feature Request] Support query for temporal schedule list #616

  2. How was this tested:

Added new tests

  1. Any docs updates needed?

@justinp-tt justinp-tt changed the base branch from main to nexus September 4, 2024 20:11
@justinp-tt justinp-tt marked this pull request as ready for review September 4, 2024 20:11
@justinp-tt justinp-tt changed the title justinp tt/list schedules query param support List schedules query param support Sep 4, 2024
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left a couple of small comments.

@justinp-tt justinp-tt self-assigned this Sep 5, 2024
@justinp-tt justinp-tt merged commit 5d2908a into nexus Sep 5, 2024
6 checks passed
@justinp-tt justinp-tt deleted the justinp-tt/list-schedules-query-param-support branch September 5, 2024 18:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants