Batch rate limit #675
Merged
Batch rate limit #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
batch-rate-limit
branch
5 times, most recently
from
2ec1be0 to
debbf70
Compare
josh-berry
approved these changes
Sep 23, 2024
temporalcli/commandsmd/commands.md
Outdated
| @@ -2530,6 +2530,7 @@ Includes options set for [payload input](#options-set-for-payload-input). | |||
| * `--yes`, `-y` (bool) - | |||
| Don't prompt to confirm signaling. | |||
| Only allowed when --query is present. | |||
| * `--rps` (float) - Limit batch's requests per second. Only allowed if query is present. | |||
There was a problem hiding this comment.
This will need to be rebased again since Andrew just merged an update that converted this file to YAML. :/ Hopefully will be straightforward, but let me know if it gets gnarly and/or you'd like me to do it.
There was a problem hiding this comment.
@josh-berry okay, rebased! Should be good now. 🤞
stephanos
force-pushed
the
batch-rate-limit
branch
from
debbf70 to
345a5d4
Compare
stephanos
force-pushed
the
batch-rate-limit
branch
from
345a5d4 to
2ebed83
Compare
cretz
approved these changes
Sep 23, 2024
temporalcli/commands.workflow.go
Outdated
| @@ -442,11 +444,17 @@ func (s *SingleWorkflowOrBatchOptions) workflowExecOrBatch( | |||
| reason = defaultReason() | |||
| } | |||
|
|
|||
| // Check rps is used together with query | |||
| if s.Rps != 0 && s.Query == "" { | |||
There was a problem hiding this comment.
This condition will never be true down here (Query is always non-empty down here, it's checked above)
There was a problem hiding this comment.
Good callout 👍 fixed!
josh-berry
approved these changes
Sep 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Rebased #551 that was never actually merged.