Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Warn users not to use dev-server in production #689

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

josh-berry
Copy link
Collaborator

No description provided.

@josh-berry josh-berry marked this pull request as ready for review October 14, 2024 15:11
@josh-berry josh-berry requested review from fairlydurable and a team October 14, 2024 15:12
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (one request)

@josh-berry
Copy link
Collaborator Author

Addressed @dandavison 's review comments and also addressed some comments from @fairlydurable offline.

@josh-berry
Copy link
Collaborator Author

Got a 👍 offline from @fairlydurable on the revised wording.

@josh-berry josh-berry merged commit aba653d into main Oct 14, 2024
7 checks passed
@josh-berry josh-berry deleted the josh/dev-server-disclaimer branch October 14, 2024 19:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants