Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

disable tq info caching in task queue test #726

Merged
merged 2 commits into from
Jan 8, 2025
Merged

disable tq info caching in task queue test #726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9911248
disable tq info caching in task queue test
carlydf Dec 9, 2024
4cb9eda
remove unecessary updates that were added to test my test fix on the …
carlydf Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions temporalcli/commands_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ func (s *SharedServerSuite) SetupSuite() {
// Allow a high rate of change to namespaces, particularly
// for the task-queue command tests.
"frontend.namespaceRPS.visibility": 10000,
// this is overridden since we don't want caching to be enabled while testing DescribeTaskQueue
// behaviour related to versioning
"matching.TaskQueueInfoByBuildIdTTL": 0 * time.Second,
Comment on lines +219 to +221
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we disable search attribute caching for all users of the dev server, not just our test suite. I wonder if we should do that here too. Though it may give the dev server users unreasonable expectations about eventual consistency for task queue info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable for the dev server to have the caching for now -- can always change it later, but I think this caching mechanism may change in the future as well

},
},
})
Expand Down
Loading