Expose the underlying slog logger to the dev server #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 18, 2024
Sushisource
approved these changes
Dec 18, 2024
josh-berry
reviewed
Dec 18, 2024
Comment on lines
+29
to
+31
| func (s slogLogger) SLog() *slog.Logger { | ||
| return s.log | ||
| } |
There was a problem hiding this comment.
Forgive the probably-dumb Go question, but I don't understand how this is being used? Is there some magic somewhere that's calling this function?
There was a problem hiding this comment.
IIUC, it's being used in the server code. So we pass a log.Logger to the server, and server-side they see if it's also a log.SLogWrapper they call this to extract the slog. (this package is where we programmatically use the server like a library)
There was a problem hiding this comment.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade server to
v1.26.2-rc.0.The server depends on the Nexus SDK, which expects an
slog.Logger, the server will do best effort conversion fromcommon/log.Logtoslog.Loggerbut providing access to the underlyingslog.Loggergives better control that the default shim provided by the server.