Rebase from main, update deps, test fixes #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.31.0 to 0.33.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR!
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->
<!--- For ALL Contributors 👇 -->
## What was changed
<!-- Describe what has changed in this PR -->
Update dependencies
## Why?
<!-- Tell your future self why have you made these changes -->
## Checklist
<!--- add/delete as needed --->
1. Closes <!-- add issue number here -->
2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
3. Any docs updates needed?
<!--- update README if applicable
or point out where to update docs.temporal.io -->
Merge remote-tracking branch 'upstream/main' into versioning-fixes
cretz
approved these changes
Feb 18, 2025
Comment on lines
+265
to
+267
| // TODO(antlai-temporal): Delete when a server caching bug in 1.26.2 is fixed, | ||
| // see https://github.com/temporalio/temporal/pull/6978 | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
It looks like this is already fixed in the server version in use? Can this sleep and the later one be removed?
There was a problem hiding this comment.
Yes, this is coming with my versioning-3 PR right after. This one just enables a draft release with the new server for testing the go sdk.
In fact, these tests just get rewritten to the new API...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This brings
mainchanges intonext-server, upgrades server and other deps, and fixes some tests for the new server/api.