Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use workflow as exclusive source of truth for orders page #10

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

prasek
Copy link
Contributor

@prasek prasek commented Sep 6, 2024

What was changed

Use workflow state as exclusive source of truth for customer order detail page

  • move shipment event listener from ShipmentStatus component to the courier shipment page
  • remove shipment event listener from customer order details page (to avoid conflicting sources of truth)

Why?

Shipment event listener in the order details page was causing a brief flickering of shipment status in the order detail.

  1. How was this tested:

MacOS 14.3.1 and Chrome 128.0.6613.114 (Official Build) (arm64)

  1. Any docs updates needed?

Nope

Signed-off-by: Phil Prasek <prasek@gmail.com>
Copy link
Collaborator

@tomwheeler tomwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and found that I was able to successfully process both single-item and multi-item orders. In all cases, the shipment status was correctly reflected in all open windows.

@tomwheeler tomwheeler merged commit fa78436 into temporalio:main Sep 9, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants