adding copy of an icon to prevent a 404 when using Safari #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I made a copy of the
apple-touch-icon.png
file namedapple-touch-icon-precomposed.png
.Why?
Just after starting the OMS web application, I opened my browser and discovered that the terminal window where the web application was running had a very ugly error. Upon reviewing the message, I found that it was an HTTP 404 error for the
apple-touch-icon-precomposed.png
file. A quick web search suggested that Safari (the browser I was using) expects a file with that name to be available and will automatically request it. Making a copy of the existing image was the easiest way of preventing this 404, which I think many developers might (like me) think was some problem with the application. Thus, suppressing that 404 will improve the developer experience.