Query buffering fixes #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
query-buffering-bug
branch
from
ff03d38
to
ae641ba
Compare
dandavison
reviewed
Jan 19, 2024
| } else { | ||
| if self.wft.is_some() { | ||
| self.query_only_tasks_for_buffered.clear(); | ||
| } | ||
| let _ = self.wft.insert(task); |
There was a problem hiding this comment.
Why is this OK -- couldn't self.wft have events and updates that we must process?
There was a problem hiding this comment.
By definition it is stale and invalid now if there's a new incoming WFT
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Made buffered queries be appropriately handled before a new "real" WFT if one is received while still handling an outstanding one.
Why?
The previous implementation banked on failing the tasks with the now "stale" queries if a new "real" WFT is received while they are buffered causing server to retry them while the client is still waiting on the query response. For whatever reason this doesn't always work. Instead, the implementation will now try to handle all buffered queries before applying the next real WFT. This potentially slows things down in very high-query-load scenarios, but that's more-or-less what Go and Java do and no one complains. Users shouldn't spam queries that hard anyway.
Checklist
Closes [Bug] Queries may still sometimes be dropped when buffering tasks #672
How was this tested: