Fix possibly sending LA marker after WF Complete command #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
la-after-wf-complete
branch
from
68654b5
to
619d65d
Compare
Sushisource
commented
Feb 2, 2024
Comment on lines
+183
to
+184
| let processing_task = thread::Builder::new() | ||
| .name("workflow-processing".to_string()) |
There was a problem hiding this comment.
Only change here is naming this thread properly. Everything else is whitespace.
Sushisource
force-pushed
the
la-after-wf-complete
branch
from
619d65d
to
76e6871
Compare
cretz
approved these changes
Feb 2, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Detect terminal commands and avoid doing anything else with LAs other than issuing cancels to outstanding ones.
Also fixed a possible shutdown hang that this surfaced.
Why?
Bugfix
Checklist
Closes [Bug] Local activity markers might create commands after workflow completion #659
How was this tested:
Added unit test which repro'd issue consistently, fixed it.
Any docs updates needed?