Wait for activity completes to reach server before shutdown #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Feb 5, 2024
|
@mjameswh we may want to modify TS to not also wait on activity completion to be delivered to the server, need to look into this. Definitely better done Core side. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Make sure we flush activity completions to server before shutting down
Why?
It's nice. We already wait for outstanding activities to complete. It makes sense to make sure we actually do something with those results.
Checklist
Closes [Feature Request] Do not complete shutdown until all activities have returned and results pushed to server #594
How was this tested:
Added UT
Any docs updates needed?