Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #250

Closed
drewhoskins-temporal opened this issue May 18, 2024 · 1 comment · Fixed by #283
Closed

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #250

drewhoskins-temporal opened this issue May 18, 2024 · 1 comment · Fixed by #283

Comments

@drewhoskins-temporal
Copy link

So that users only have to catch one predictable exception
Open
8 tasks
@drewhoskins-temporal drewhoskins-temporal changed the title Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update May 18, 2024
@cretz
Copy link
Member

cretz commented Jun 5, 2024

See temporalio/features#483 (comment) for implementation details

cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Jun 20, 2024
@cretz
Add workflow update RPC timeout/canceled exception
5d264d9 
Fixes temporalio#250
@cretz cretz mentioned this issue Jun 20, 2024
Merged
@cretz cretz closed this as completed in 8b430c4 Jun 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add workflow update RPC timeout/canceled exception cretz/temporal-sdk-dotnet
2 participants
@cretz @drewhoskins-temporal