Prevent Windows 2022 being used for native-images #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraalVM doesn't have an SDK for Windows Server 2022 yet so the native executable build fails if we catch an updated builder. Windows 2022 is becoming the default for `windows-latest` "real soon now" so pin the version in use to 2019. More context at actions/runner-images#4856
mmcshane
requested review from
bergundy,
cretz,
mfateev,
Spikhalskiy and
Sushisource
as code owners
Spikhalskiy
approved these changes
Jan 28, 2022
Spikhalskiy
approved these changes
Jan 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Require windows-2019 for native image builds rather than windows-latest
Why?
GraalVM doesn't have an SDK for Windows Server 2022 yet so the native
executable build fails if we catch an updated builder. Windows 2022 is
becoming the default for
windows-latest"real soon now" so pin theversion in use to 2019.
More context at actions/runner-images#4856
Checklist
Closes
How was this tested: