Expose OrchestratorServiceStubs #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
force-pushed
the
issue-882
branch
19 times, most recently
from
c2c7a07 to
b945e10
Compare
Spikhalskiy
changed the title
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
issue-882
branch
2 times, most recently
from
cb97813 to
ba39824
Compare
cretz
reviewed
Mar 7, 2022
temporal-serviceclient/src/main/java/io/temporal/serviceclient/OperatorServiceStubs.java
Show resolved
Hide resolved
temporal-serviceclient/src/main/java/io/temporal/serviceclient/ChannelManager.java
Outdated
Show resolved
Hide resolved
| this.channel = options.getChannel(); | ||
| this.grpcConnectionManager = null; | ||
| } else { | ||
| this.channel = prepareChannel(); |
There was a problem hiding this comment.
To confirm, by default we are intentionally creating separate channels for different gRPC services on the same server? I haven't put in thought to how the API would look if you wanted to share them, but I just want to make sure that is intentional.
There was a problem hiding this comment.
Yes. By default, every Stubs creates its own channel. It happens now if we create several WorkflowServiceStubs too. At the same time, if the users really want, they can reuse the channel. I exposed ServiceStubs#getRawChannel and the channel can be taken from the existing stubs and reused in the Options for a new stub.
Also, keep in mind that a regular App shouldn't be creating OperatorServiceStubs at all.
temporal-serviceclient/src/main/java/io/temporal/serviceclient/OperatorServiceStubsImpl.java
Outdated
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
issue-882
branch
4 times, most recently
from
26704b8 to
22a01ed
Compare
cretz
approved these changes
Mar 7, 2022
Spikhalskiy
force-pushed
the
issue-882
branch
2 times, most recently
from
a070874 to
afb5f01
Compare
Allow users to register search attributes using sdk Refactoring of WorkflowServiceStubs to reduce code duplication Issue temporalio#882
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowServiceStubsImpl was refactored to reduce code duplication
Why?
Allow users to register search attributes using sdk
Refactoring of WorkflowServiceStubs to reduce code duplication
Closes #882