Improve client WorkflowFailedException message with the reason #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Improves top client WorkflowFailedException message by making it more human-readable and enriches it with the reason (terminated, canceled, timed_out, failed) to make what happened with the workflow immediately clear without looking at the root exception down the stack. Simplifies exception wrapping and handling to avoid non-needed intermediate representation.
Spikhalskiy
force-pushed
the
workflowfailedexception-eventid
branch
from
74dac80 to
e943114
Compare
cretz
approved these changes
Mar 23, 2022
| long workflowTaskCompletedEventId, | ||
| RetryState retryState) { | ||
| return "workflowId='" | ||
| return "Workflow execution " |
There was a problem hiding this comment.
This would look much nicer with Guava's MoreObjects.ToStringHelper :-)
There was a problem hiding this comment.
We try our best to don't use Guava where it's not absolutely needed :) Also, this one is not a standard toString, it's a message and it's customized a little.
There was a problem hiding this comment.
I find even a string builder is easier to read than all these concatenations (granted that's what the JVM compiles this down to anyways)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves top client
WorkflowFailedExceptionmessage by making it more human-readable and enriches it with the reason (terminated, canceled, timed_out, failed) to make what happened with the workflow immediately clear without looking at the root exception down the stack.Simplifies exception wrapping and handling to avoid non-needed intermediate representation.
Before:
WorkflowExecutionUtils.getResultFromCloseEventthrows internalWorkflowExecutionFailedExceptionand client facingWorkflowFailedException.WorkflowExecutionFailedExceptiongets converted toWorkflowFailedExceptionhigher in the chain (in the stubs themselves).After:
WorkflowExecutionUtils.getResultFromCloseEventthrows justWorkflowFailedException.