Explicit methods for lazy and eager connecting client, new #healthCheck method on stubs #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
issue-828
branch
2 times, most recently
from
cac6543 to
b2a517b
Compare
|
@Spikhalskiy looks like we need to discuss this behavior again, waiting with this review. |
|
@bergundy that's why it's a draft ;) I will finalize it after the discussion of our Stubs contract. |
Spikhalskiy
force-pushed
the
issue-828
branch
10 times, most recently
from
5e2a3e0 to
d56b956
Compare
Spikhalskiy
changed the title
cretz
reviewed
Apr 29, 2022
temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java
Show resolved
Hide resolved
cretz
approved these changes
Apr 29, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and Implemented
ServiceStubs#healthCheck(), make eager health check during client creation disabled by default.Closes #828
Corresponded GoSDK change: temporalio/sdk-go#795