Make getResult methods to throw TimeoutException instead of raw gRPC DEADLINE_EXCEEDED #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
force-pushed
the
issue-1177
branch
3 times, most recently
from
a67716e to
40685f8
Compare
Spikhalskiy
force-pushed
the
issue-1177
branch
5 times, most recently
from
8ae4a9d to
dde1bdc
Compare
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Sushisource
approved these changes
May 13, 2022
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowStubImpl.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/client/WorkflowClientLongPollAsyncHelper.java
Show resolved
Hide resolved
temporal-serviceclient/src/main/java/io/temporal/internal/retryer/GrpcRetryerUtils.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * These tests are intentionally running longer than a minute to cover a situation when getResult | ||
| * calls needs to survive a server timeout on a long poll of 60 seconds to get the result of |
There was a problem hiding this comment.
Any reason not to just crank down the poll timeout a bit?
There was a problem hiding this comment.
I want to test a situation when the server responds with an empty result, not when we hit a long poll timeout. And for that, I have to get over 20 seconds (this is the default behavior right now, the server cuts history long polls in 20 seconds and returns an empty history). Or modify the settings of our server, which I don't want to abuse.
Spikhalskiy
force-pushed
the
issue-1177
branch
5 times, most recently
from
a8f0a33 to
822a8e5
Compare
…DEADLINE_EXCEEDED getResultAsync now respects the timeout Issue temporalio#1177 Issue temporalio#988
Spikhalskiy
force-pushed
the
issue-1177
branch
3 times, most recently
from
d4bdf45 to
986329d
Compare
…DEADLINE_EXCEEDED getResultAsync now respects the timeout Issue temporalio#1177 Issue temporalio#988
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Make getResult methods to throw
TimeoutExceptionas the method contract states instead of raw gRPC DEADLINE_EXCEEDED.getResultAsync now respects the timeout.
Unit tests are added that are covering different kinds of timeouts and retries of the long poll.
Closes #1177
Closes #988
Closes #1203