Cleanup never used confusing ActivityTaskHandler#Result#requestRetryOptions #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
force-pushed
the
activity-handler-cleanup
branch
4 times, most recently
from
6e33e11 to
da6a711
Compare
…ptions Replace synthetic activity schedule to close test with a real one.
Spikhalskiy
force-pushed
the
activity-handler-cleanup
branch
from
da6a711 to
2bf8365
Compare
Sushisource
approved these changes
Jun 17, 2022
Spikhalskiy
requested review from
mfateev,
cretz,
bergundy and
mmcshane
as code owners
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace synthetic activity schedule to close test with a real one.
Refactoring PR focused on reducing dead code and improving clarity