Rework LocalActivities waiting code to use nanoseconds #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Sushisource
reviewed
Jun 22, 2022
| * FORCED_DECISION_TIME_COEFFICIENT); | ||
| long nextForcedDecisionTime = startTime + forcedDecisionTimeout; | ||
|
|
||
| long nextForcedDecisionTimeNanos = startTimeNanos + forcedDecisionTimeoutNanos; |
There was a problem hiding this comment.
Should say WFT instead of Decision
Sushisource
reviewed
Jun 22, 2022
...oral-sdk/src/main/java/io/temporal/internal/statemachines/InternalWorkflowTaskException.java
Outdated
Show resolved
Hide resolved
Sushisource
approved these changes
Jun 22, 2022
Spikhalskiy
force-pushed
the
rework-la-wait-code-to-nanos
branch
from
044bd36 to
2860378
Compare
Spikhalskiy
force-pushed
the
rework-la-wait-code-to-nanos
branch
from
2860378 to
0f8f6c6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Rework LocalActivities waiting code to use nanoseconds
Some other refactorings improving comprehension
Why?
System.currentTimeMillis shouldn't be used for timeouts and it's non monotonic