Add log waring if workflow eviction / closure is taking too long time to close #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
message-on-non-ability-to-destroy-thread
branch
5 times, most recently
from
4972791 to
7532a52
Compare
Sushisource
reviewed
Jun 27, 2022
temporal-sdk/src/main/java/io/temporal/internal/sync/DeterministicRunnerImpl.java
Outdated
Show resolved
Hide resolved
Sushisource
reviewed
Jun 27, 2022
temporal-sdk/src/main/java/io/temporal/internal/sync/DeterministicRunnerImpl.java
Outdated
Show resolved
Hide resolved
Sushisource
reviewed
Jun 27, 2022
temporal-sdk/src/main/java/io/temporal/internal/sync/DeterministicRunnerImpl.java
Show resolved
Hide resolved
Sushisource
reviewed
Jun 27, 2022
temporal-sdk/src/main/java/io/temporal/internal/sync/DeterministicRunnerImpl.java
Outdated
Show resolved
Hide resolved
Sushisource
approved these changes
Jun 27, 2022
…e to close Add guards making sure all threads are drained.
Spikhalskiy
force-pushed
the
message-on-non-ability-to-destroy-thread
branch
from
7532a52 to
d4f863d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add log warning if workflow eviction / closure is taking too long time to close.
Add guards making sure all threads are drained.