Fix getOriginalExecutionRunId return value and add explicit @NonNull annotations #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
approved these changes
Apr 12, 2023
Spikhalskiy
force-pushed
the
getOriginalRunId-return-fix
branch
from
29d8cc4 to
3b5127b
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While adding
getOriginalExecutionRunIdmethod in the previous release I made a mistake by copyinggetContinuedExecutionRunIdsignature and made the return valueOptional<String>.This is an incorrect type and makes users think that they should account for situations when this value is not present.
This change is backward incompatible for users of
getOriginalExecutionRunIdmethod and will require a trivial refactoring. I expect the number of users to be affected as close to 0, because this method is not just very new and silently added for a specific user, but also most users should never use it and go forgetFirstExecutionRunIdinstead.