Skip to content

WorkerOptions extend javadocs for default values #1774

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

p4p4
Copy link
Contributor

@p4p4 p4p4 commented Jun 1, 2023

What was changed

added info about setting to 0 causes using the default value for the following methods:

  • setMaxConcurrentWorkflowTaskPollers
  • setWorkflowPollThreadCount (deprecated)
  • setMaxConcurrentActivityTaskPollers
  • setActivityPollThreadCount (deprecated)

Why?

I had to look up the code to find out about this behaviour. For other methods, the behaviour of setting to 0 was documented, e.g.

  • setMaxConcurrentWorkflowTaskExecutionSize(1)
  • setMaxConcurrentActivityExecutionSize(1)

@p4p4 p4p4 requested a review from a team as a code owner June 1, 2023 08:53
@CLAassistant
Copy link

CLAassistant commented Jun 1, 2023

CLA assistant check
All committers have signed the CLA.

@Quinn-With-Two-Ns
Copy link
Contributor

Hi @p4p4 Thanks for the contribution, could you sign our CLA please?

@Quinn-With-Two-Ns
Copy link
Contributor

I believe CI is failing here because your branch does not have tags. I believe you can run git fetch --tags --all

@p4p4 p4p4 force-pushed the feature/WorkerOptions-javadocs branch from 456a50c to fed160f Compare June 13, 2023 20:43
@p4p4
Copy link
Contributor Author

p4p4 commented Jun 13, 2023

I tried the following, but seems the build is still failing

git remote add upstream https://github.com/temporalio/sdk-java.git
git fetch upstream
git rebase upstream/master
git push -f
git push --tags

@Quinn-With-Two-Ns
Copy link
Contributor

@p4p4 You did the right things, your build is failing because some other pull request raced and broke master. Once that is fixed I will rebase your PR.

@Quinn-With-Two-Ns
Copy link
Contributor

@p4p4 looks like I don't have permission to rebase. If you can rebase on master when you get a chance it would be appreciated. Sorry for the extra effort.

added info about setting to 0 causes using the default value
for the following methods:
- setMaxConcurrentWorkflowTaskPollers
- setWorkflowPollThreadCount (deprecated)
- setMaxConcurrentActivityTaskPollers
- setActivityPollThreadCount (deprecated)
@p4p4 p4p4 force-pushed the feature/WorkerOptions-javadocs branch from fed160f to 092eba3 Compare June 17, 2023 20:01
@p4p4
Copy link
Contributor Author

p4p4 commented Jun 18, 2023

rebased

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 479cf4b into temporalio:master Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants