Test Server: Fix Nexus operation timeout during retry #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -789,7 +789,12 @@ private static void timeoutNexusOperation( | |||
| private static State failNexusOperation( | |||
| RequestContext ctx, NexusOperationData data, Failure failure, long notUsed) { | |||
| RetryState retryState = attemptNexusOperationRetry(ctx, Optional.of(failure), data); | |||
| if (retryState == RetryState.RETRY_STATE_IN_PROGRESS) { | |||
| if (retryState == RetryState.RETRY_STATE_IN_PROGRESS | |||
There was a problem hiding this comment.
Hm but in the test why are we even reaching this point since the error thrown should never fail the operation?
There was a problem hiding this comment.
This function is also for handling task failures. I guess maybe @bergundy was right and I should separate out a FAIL_ATTEMPT from failing the operation as a whole. But this is how workflow and activity task failures/retries are handled and I though it would be better to stay consistent and refactor them all at the same time.
Quinn-With-Two-Ns
approved these changes
Sep 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed test server logic to not immediately record a failure if the next attempt schedule time would exceed an operation's schedule to close timeout.
Why?
Closes #2215